Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SOURCE_DATE_EPOCH in version timestamps #2943

Merged

Conversation

gioele
Copy link
Contributor

@gioele gioele commented Nov 6, 2016

This PR pushes upstream a patch carried by Debian since long time. It is safe to apply, does not interfere with the normal packaging workflow and make Fontforge a good citizen. :)

This is unrelated to issues #2490 and #2711: those issues are about timestamps in generated font files, this is PR has to do with the packaging of Fontforge itself.

Commit message:

To allow package to build reproducibly use SOURCE_DATE_EPOCH as
mentioned in https://reproducible-builds.org/specs/source-date-epoch/.

@gioele
Copy link
Contributor Author

gioele commented Nov 6, 2016

The current date invocation is not compatible with the OSX date command. I will revise this PR later to make it work on both GNU and OSX systems.

@gioele gioele force-pushed the debian-reproducible-buildtimestamps branch from e800e78 to 28120fb Compare November 8, 2016 22:18
@gioele
Copy link
Contributor Author

gioele commented Nov 8, 2016

I updated the PR with the necessary changes for Mac OS X. Now Travis is happy again.

@gioele gioele force-pushed the debian-reproducible-buildtimestamps branch from 28120fb to 102978a Compare November 10, 2016 19:50
@frank-trampe
Copy link
Contributor

Okay.

@frank-trampe frank-trampe merged commit 24894f9 into fontforge:master Nov 17, 2016
@gioele gioele deleted the debian-reproducible-buildtimestamps branch November 22, 2016 21:08
Omnikron13 pushed a commit to Omnikron13/fontforge that referenced this pull request May 31, 2022
…ldtimestamps

Use SOURCE_DATE_EPOCH in version timestamps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants