Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debian-old directory #2946

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Conversation

gioele
Copy link
Contributor

@gioele gioele commented Nov 6, 2016

The packaging files for Debian are stored in Packaging/debian since
commit 58a4dfb.

The Debian maintainers confirmed that that directory is not used by them,
see the thread "debian-old directory in fontforge: somehow useful?". [1]

[1] http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/2016-November/018587.html

@JoesCat
Copy link
Contributor

JoesCat commented Nov 6, 2016

I'm plus one for removing it as we should ideally have the ./configure stuff correctly setup for "everyone", however, since I'm not the one building compiled releases, this is best answered by @frank-trampe and @jtanx.
This pull request may need some things to happen with configure.ac and the m4 directory before safely removing it. I would recommend checking Debian's fixes, Fedora's, and the BSD distros for internal fixes that can probably be pulled in, ...homebrew and macports may also have some fixes too.

@gioele
Copy link
Contributor Author

gioele commented Nov 6, 2016

Hi @JoesCat, I also thought about all those things, but it turns out that that directory is just an old snapshot of the Debian packaging stuff.

Years ago (commit 97843f0) @frank-trampe disconnected that directory from the whole build system and has been left there to take dust. As I wrote in the commit message, the Debian maintainers reassured me in http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/2016-November/018587.html that...

Ah. Feel free to delete in upstream :-). Debian teams create their own
packaging stuffs. We ignore packaging from upstream anyway.

WRT integrating patches, there is only one non-Debian specific patch that I have found in the Debian repository (and not in debian-old), the one in PR #2943 (unfortunately broken on OS X, will fix it soon when I get access to my OS X machine).

@frank-trampe
Copy link
Contributor

As far as I remember, I never used the contents of the directory, and I'm not sure whether they were ever used upstream.

@JoesCat
Copy link
Contributor

JoesCat commented Nov 8, 2016

Would it be worth moving fontforge.xpm into the desktop/icon-older directory?

@JoesCat
Copy link
Contributor

JoesCat commented Nov 10, 2016

Hi @gioele - i think i probably broke this merge by moving a file out (for old nostalgic reasons).
Would you mind regenerating this so it will merge without problems?
Sorry about creating extra work.
I don't think there appears to be any objections, so, once it appears okay, just go ahead and merge it.

Thanks,
Joe

The packaging files for Debian are stored in `Packaging/debian` since
commit 58a4dfb.

The Debian maintainers confirmed that that directory is not used by them,
see the thread "debian-old directory in fontforge: somehow useful?". [1]

[1] http://lists.alioth.debian.org/pipermail/pkg-fonts-devel/2016-November/018587.html
@gioele gioele merged commit ab39658 into fontforge:master Nov 10, 2016
@gioele gioele deleted the remove-debian-old branch November 10, 2016 19:31
Omnikron13 pushed a commit to Omnikron13/fontforge that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants