Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Startup fixes #4827

Merged
merged 3 commits into from Oct 5, 2021
Merged

Mac Startup fixes #4827

merged 3 commits into from Oct 5, 2021

Conversation

jtanx
Copy link
Contributor

@jtanx jtanx commented Oct 3, 2021

See commit messages for more info

Me writing Objetive C:
wat

Type of change

  • Bug fix

Closes #4082
Closes #2042
Closes #4653

Also use Cocoa event handlers instead of Carbon event handlers.
Also fix handling of the open documents request on startup.
char *pt, *path, *program_dir=NULL;
char filename[2000];

if (prog == NULL) {
return NULL;
}

#if defined(__MINGW32__)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code

<key>CFBundleName</key>
<string>FontForge</string>
<key>CFBundleExecutable</key>
<string>../Resources/opt/local/bin/fontforge</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in that issue thread, the bundle now executes the binary directly instead of going through a script.

This will cause Gatekeeper to prompt the user if they wish to allow FF to access that location instead of silently denying access.

@lgtm-com
Copy link

lgtm-com bot commented Oct 3, 2021

This pull request fixes 1 alert when merging f1492c9 into ed8c026 - view on LGTM.com

fixed alerts:

  • 1 for Function declared in block

ubuntu-16.04 was removed from GH Actions
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2021

This pull request fixes 1 alert when merging 583d505 into ed8c026 - view on LGTM.com

fixed alerts:

  • 1 for Function declared in block

@jtanx jtanx closed this Oct 5, 2021
@jtanx jtanx reopened this Oct 5, 2021
@jtanx jtanx merged commit dc7b81b into fontforge:master Oct 5, 2021
@jtanx jtanx deleted the appb branch October 5, 2021 00:49
@frank-trampe
Copy link
Contributor

I don't know Objective C either, but I'm going to say "good job" based upon the fact that this passes tests and closes issues. Good job!

@ancestral
Copy link

@jtanx Is there a reason you named the file Info.plist.in instead of Info.plist?

@skef
Copy link
Contributor

skef commented Feb 1, 2022

@ancestral In general files in the FontForge repository with .in suffixes are templates processed by CMake, which will save the template output in the name without the suffix. In this case CMake is being used to replace @@ strings like @PROJECT_VERSION@ with appropriate build-specific values.

Omnikron13 pushed a commit to Omnikron13/fontforge that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants