New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac Startup fixes #4827
Mac Startup fixes #4827
Conversation
Also use Cocoa event handlers instead of Carbon event handlers. Also fix handling of the open documents request on startup.
char *pt, *path, *program_dir=NULL; | ||
char filename[2000]; | ||
|
||
if (prog == NULL) { | ||
return NULL; | ||
} | ||
|
||
#if defined(__MINGW32__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code
<key>CFBundleName</key> | ||
<string>FontForge</string> | ||
<key>CFBundleExecutable</key> | ||
<string>../Resources/opt/local/bin/fontforge</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in that issue thread, the bundle now executes the binary directly instead of going through a script.
This will cause Gatekeeper to prompt the user if they wish to allow FF to access that location instead of silently denying access.
This pull request fixes 1 alert when merging f1492c9 into ed8c026 - view on LGTM.com fixed alerts:
|
ubuntu-16.04 was removed from GH Actions
This pull request fixes 1 alert when merging 583d505 into ed8c026 - view on LGTM.com fixed alerts:
|
I don't know Objective C either, but I'm going to say "good job" based upon the fact that this passes tests and closes issues. Good job! |
@jtanx Is there a reason you named the file |
@ancestral In general files in the FontForge repository with |
Mac Startup fixes
See commit messages for more info
Me writing Objetive C:
Type of change
Closes #4082
Closes #2042
Closes #4653