Glyph renaming - disable auto-bleed in all contexts #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SFGlyphRenameFixup() is too smart that it will, when renaming “f”, it will search for glyphs that has an “f” component, e.g. “f_f” or “f_f_i” and rename the component as well. The desirability of this is questionable, but for now I added a boolean flag to control this and disable it in Python while keeping the GUI behaviour unchanged. Commits / fc92548, see issue 523 "Remove the auto glyph renaming feature."
These things can get forgotten later - better highlight a note.
…into glyph_renaming
ghost
mentioned this pull request
Closed
|
I hope @JoesCat can review and merge this :D Really great to see this collaboration, especially with Khaled :) |
|
Tried your sample code for before: Also tried SelectNone() just before Select("foo") or Select(0), as well as SelectAll() afterwards. I have not yet dug-in deeper into issues you have mentioned such as substitution tables or other features, so that might come to bite-us later on, but this seems to be working okay for what is shown at this point. Thanks for catching the missing splinefont.h file - I don't work in my master, but only in a copy, and missed copying that file earlier. Looks ready to merge |
JoesCat
added a commit
that referenced
this pull request
Apr 12, 2013
Glyph renaming - disable auto-bleed in all contexts
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion, as an expansion of @JoesCat's #524. I have fixed the minor issue with the function prototype, but more importantly, disabled auto-rename in all contexts; not only Python scripting but also native scripting and the GUI. This brings it into line with my own preferences and issue #523. The code to do the auto-renaming still exists, but with this patch it will not execute; I'd support a future feature request to make it available as a separate command distinct from regular rename.
I've tested this to the extent possible and am reasonably sure it won't create inconsistent substitution tables; that bit of existing code turns out to be better-designed than I had feared.