-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual diff #238
Comments
@andriyko do you think you may complete this before Dec 1? :) |
Okay, no time for this year :) |
Similar discussion at googlefonts/roboto-2#30 |
google/fonts#24 fixed an issue that this should be catching here are the broken originals: Here are the fixed fonts: @graphicore has developed a project specific comparison tool which could be the basis for something PhantomJS based here: http://tarobish.github.io/Jomhuria/#tests/collision-above-3 |
If winniethemu/tiff#2 is closed, potentially embed tiff :) There are now more font diffing tools; https://typeresources.github.io/glyph-gazer/ and https://github.com/googlei18n/fontdiff and perhaps more. |
Following #246,
/builds/
(that is, all the$gitHash.buildID/
directories) to thegh-pages
branchFirst thing is a timeline browser. Simplest thing would be a paginated table with a list of the builds, like in the old FontBakery Web App, that allows you to select 2 builds and hit a compare button.
(In the future this will become a long list, so filtering will be needed. To limit the table to a smaller time span, a graph like a Github year-long block graph of activity could work well to visualise intensity of activity:
If this could be 'scaled' up to decade and down to month, week, day, you could pick an interesting way point easily. But that's for far in the future.)
The addition/removal of files could be done with the existing JSON-Diff JS that is used to compare METADATA.json files, if a python
os.walk()
is used to output a JSON representation of the directory that is deployed... However, we also need to show filesize changes, so perhaps it could be done with a 2 pane (or 2+ pane) view like http://meldmerge.org uses.(Again, the old Font Bakery Web App did the YAML/XML diff and might have code we can reuse)
The text was updated successfully, but these errors were encountered: