Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getNumber, if given a default, guarantees the return type is of type number #130

Merged
merged 1 commit into from
Jan 3, 2023
Merged

fix: getNumber, if given a default, guarantees the return type is of type number #130

merged 1 commit into from
Jan 3, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 3, 2023 •
edited
Loading

overloads so that
getNumber, if given a default, guarantees the return type is of type number

before

Screen Shot 2023-01-03 at 10 29 35 AM

after

Screen Shot 2023-01-03 at 10 31 57 AM

@mshanemc mshanemc merged commit 14a9cf7 into main Jan 3, 2023
@mshanemc mshanemc deleted the sm/better-env-typing branch January 3, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @peternhale