New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: map/set logging #317

Merged

cristiand391 merged 1 commit into main from sm/set-map-logging

May 24, 2024

Contributor

mshanemc commented May 24, 2024

JSON.stringify of Map/Set produce {}
we want to stringify "object" generally, but not those 2 cases (possibly more, haven't seen those yet)

note: isPlainObject from ts-types also returns true for Map/Set and didn't help


          fix: map/set logging

907ea64

mshanemc requested a review from a team as a code owner

May 24, 2024 14:02

cristiand391 approved these changes

View reviewed changes

cristiand391 merged commit fcb0973 into main

13 of 14 checks passed

cristiand391 deleted the sm/set-map-logging branch

May 24, 2024 14:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet