Migrate update main image background job to sidekiq #5345
Conversation
This is a port of app/jobs/update_main_image_background_job.rb that works with Sidekiq instead of DelayedJob.
This updates all references to UpdateMainImageBackgroundHexJob so they now call UpdateMainImageBackgroundHexWorker, which works with Sidekiq instead of DelayedJob.
|
|
There was a problem hiding this comment.
Hi @codekatas-magmalabs, thanks a lot for your PR!
I think the code is fine, maybe we'll have to reconsider the priority but overall it's a solid PR.
There's one failing test though, see https://travis-ci.com/thepracticaldev/dev.to/builds/142954923, the reason why it's failing it's because the test is using assert_enqueued_with which is based on ActiveJob, but we're not using that anymore. You can replace it with sidekiq_assert_enqueued_with, see my comment here: #5305 (comment)
Thank you!
pr-triage
bot
added
PR: reviewed-changes-requested
|
Also, don't forget to sign the CLA up here |
|
Hey @codekatas-magmalabs, thanks for the contribution! Would you like to update the specs as Rhymes mentioned? I know life has funny ways of getting busy. I'm happy to update it or assist as well if that's easier, just let me know. Thanks! |
| @@ -429,7 +429,7 @@ def evaluate_markdown | |||
| def update_main_image_background_hex | |||
There was a problem hiding this comment.
This is also being triggered in an after_save callback which means the record will not be in the database yet if it is new. Can you change this so it's fired in an after_commit callback? THANK YOU!
pr-triage
bot
added
PR: unreviewed
|
@codekatas-magmalabs I went ahead and pushed up the requested changes. We're in the home stretch of finishing off this epic (#5305). Thank you so much for getting this going and please let me know if you have any questions! |
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#5305
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?