Use page location as indicator for page load #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
approved these changes
Jan 27, 2020
| if ( | ||
| document.getElementById('notifications-container') == null | ||
| window.location.pathname !== '/notifications' | ||
| ) { | ||
| var xmlhttp; | ||
| if (window.XMLHttpRequest) { |
There was a problem hiding this comment.
A couple of suggestions which could be in another small PR is just some cleanup, e.g. document.getElementById('notifications-number') could be defined once before the if/else and consider moving towards fetch.
There was a problem hiding this comment.
Yeah, definitely
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
We check for notifications count in the app shell before the rest of the page loads or is available, so we actually don't know whether
document.getElementById('notifications-container') == nullis a thing either way.This code used to be called after the rest of the page loads.
This ensures we don't show the number if anyone lands directly on the notifications page.