Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ about changing Twitter/GitHub username with info about self-removing an association #5736

Closed
wants to merge 1 commit into from

Conversation

mkf
Copy link
Contributor

@mkf mkf commented Jan 27, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

In FAQ, under How do I change my Twitter/GitHub username?, below Email yo@dev.to and we'll take care of it., adds If you are authenticating with the other one of the two, you can also head to <a href="https://dev.to/settings/account">Settings &gt; Account</a> and remove and then reässociate the one that you want to change yourself..

Related Tickets & Documents

Idk, #820 ig

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

didn't run, my change seems fine 😉

EDIT: I did a thing with devtools, although it is not processed by erb and stuff but just added to output:
2020-01-27-032759_876x261_scrot

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
Copy link
Contributor

@citizen428 citizen428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkf, this seems like a useful addition.

@rhymes rhymes requested review from jacobherrington and removed request for maestromac January 27, 2020 10:10
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea and might help cut down on the number of requests we get from users.

I made a couple of suggestions regarding the way this is worded, let me know what you think!

Thanks for contributing @mkf 👍 👏

@@ -49,6 +49,7 @@
<b>How do I change my Twitter/GitHub username?</b>
<br>
Email yo@dev.to and we'll take care of it.
If you are authenticating with the other one of the two, you can also head to <a href="https://dev.to/settings/account">Settings &gt; Account</a> and remove and then reässociate the one that you want to change yourself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the verbiage in this change, perhaps it can be simplified to something like:

You can also remove your associated account and re-authenticate in your <a href="https://dev.to/settings/account">Account Settings</a>.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an A-diaeresis that shouldn't be here: reässociate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an A-diaeresis that shouldn't be here: reässociate.

It indicates that both vowels are pronounced independently, not as a dipthong. I think the only English language publication where I regularly see this is the New Yorker (e.g. coöperate).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an A-diaeresis that shouldn't be here: reässociate.

It indicates that both vowels are pronounced independently, not as a dipthong. I think the only English language publication where I regularly see this is the New Yorker (e.g. coöperate).

Recently I have been typing a lot of stuff with æ not long ago and somehow confused it for a diphtong in the English language.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the verbiage in this change, perhaps it can be simplified to something like:

You can also remove your associated account and re-authenticate in your <a href="https://dev.to/settings/account">Account Settings</a>.

I believe we should highlight that another association must be present, and that this other association will become the only way of authentication — so it must be taken care of not to lose that other associated account… especially to make sure that even the right one is connected. Also to differentiate that from the "email us" preceding option i believe it is important to highlight the yourselfness of this action. Also I believe using reassociate is a better choice since reauthenticate might be misunderstood; maybe reauthenticate it, but I'm still not sure about it.

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
@mkf
Copy link
Contributor Author

mkf commented Jan 28, 2020

Thanks for contributing @mkf

I just felt weird about having the sticker and only having done Mastodon list additions, and then seeing this be so out of date.

@maestromac
Copy link
Contributor

Hello @mkf , It's been quite a bit of time and we've drastically changed our FAQ page as part of Page model. We've also updated the portion regarding changing Twitter/GitHub username. Thanks again for your contribution.

@maestromac maestromac closed this Mar 5, 2020
@mkf
Copy link
Contributor Author

mkf commented Mar 6, 2020

Hello @mkf , It's been quite a bit of time and we've drastically changed our FAQ page as part of Page model. We've also updated the portion regarding changing Twitter/GitHub username. Thanks again for your contribution.

@maestromac I have just been very busy and couldn't get myself to even remember about it let alone sit down to it. Glad you got it done. I like the new wording, couldn't get it better myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants