Don't escape markup sensitive characters in <title> #5788
Conversation
|
Ahh, just realized |
| @@ -10,7 +10,7 @@ | |||
| <% if @shell %> | |||
| <script defer> | |||
| if (!document.title) { | |||
| document.title = document.getElementsByTagName("TITLE")[1].innerHTML | |||
| document.title = document.getElementsByTagName("TITLE")[1].textContent | |||
There was a problem hiding this comment.
This would fix the issue, but I'm not sure why this piece of code exists. I did a document.getElementsByTagName('title') from the home page and an article page and both currently yield 5 <title /> tags.
The first one is the document's title and the other 4 are titles for <svg /> elements. e.g.
There was a problem hiding this comment.
I'm a little late to this but I don't think this is no longer an issue @nickytonline
|
@nickytonline is still an issue in your opinion? The article that prompted this issue related to this PR seems fine: https://dev.to/astrit/why-how-did-i-build-500-css-only-icons-library-a-life-story-34on |
|
@rhymes it is.
|
|
@Defman21 my mistake! For some reason I thought the issue was about the title we display, not the HTML |
|
Hmm, this could be a browser-specific issue. Of course we still need to address it
|
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
Avoids broken titles like
The DEV <> Stackbit integration is in the running for a Product Hunt "Golden Kitty Award"by replacing.innerHTMLwith.textContentwhich gets a raw copy of text node content.❗️This bug only appears when articles are not accessed via internal navigation.
Related Tickets & Documents
Closes #5226
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?