Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/events show 404 #5798

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Fix/events show 404 #5798

merged 3 commits into from
Feb 3, 2020

Conversation

Zeko369
Copy link
Contributor

@Zeko369 Zeko369 commented Jan 28, 2020 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Return 404 if event is not found instead of getting an error

Related Tickets & Documents

closes #5795

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 28, 2020
@claassistantio
Copy link

claassistantio commented Jan 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

rhymes
rhymes approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zeko369!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 30, 2020
@Zeko369 Zeko369 requested a review from mstruve February 2, 2020 14:23
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
@mstruve mstruve merged commit cba4e99 into forem:master Feb 3, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 3, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return a 404 response If @event is Not Found
4 participants
@Zeko369 @claassistantio @rhymes @mstruve