Refactor ProfileImage

[websebdev]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

As suggested by @citizen428, here's the minor refactor to go from ProfileImage.new.get(150) to ProfileImage.new.get(width: 150). This makes the get method more explicit on what it actually does and also allows later, if needed, to easily add more optional arguments like height.

Related Tickets & Documents

#5583 (comment)

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[citizen428]

I ❤️ this so much, I think it's way easier for the reader of the code. Thanks @seb1441!

[rhymes]

LGTM!

[Zhao-Andy]

Great refactor, thanks for the PR!

[mstruve]

Shoot, we waited a little too long on this! @seb1441 any chance you can resolve the conflict that we have? Or maybe @rhymes can do it quickly since he is very familiar with those API builders.

[rhymes]

For some reason, probably permissions, I can't resolve this conflict:

I rebased the branch manually to see where the conflict was and the issue is that app/views/api/v0/users/me.json.jbuilder does not exist anymore in master.

These are the steps to do it manually:

$ git rebase master # with master up to date
$ git rm app/views/api/v0/users/me.json.jbuilder
$ git rebase --continue
$ git push -f # if you have permission to write to this PR

[websebdev]

@rhymes Thank you for the steps, it worked perfectly. Weird that you had permissions issues. When I create PR's, I always check the box to let the maintainers have access to my repo. Maybe because the permissions are only on the branch related and not the master branch?

@mstruve Conflict fixed!

[rhymes]

@seb1441 it looks like there are a few broken specs this time around https://travis-ci.com/thepracticaldev/dev.to/builds/147858632 - likely new specs using the old signature, that entered with the rebase :)

Sorry for this!

[websebdev]

@rhymes Newly added tests fixed :)

[citizen428]

Thanks for fixing this @seb1441!

[mstruve]

Thank you @seb1441 for your patience with this, I plan on getting this merged later today(unless someone beats me to it) to avoid any more conflicts!!!