Style: update height of speakerdeck tag to be avoid scaling #5818
Conversation
|
|
rhymes
requested review from
lisasy and
ludwiczakpawel
and removed request for
rhymes,
benhalpern,
jessleenyc and
lisasy
pr-triage
bot
added
PR: reviewed-approved
There was a problem hiding this comment.
The problem is actually couple lines above, not here. Check out line #5 - it does some weird magic around calculating padding-bottom. Assuming all speakerdeck presentations have 16:9 ratio, this value should be set to 56.25%. More about the solution itself can be find here: https://benmarshall.me/responsive-iframes/
If you set it like that, all should be good without making changes to the height itself. That change is actually not ideal - it does indeed make it look okey-ish but it will break in certain scenarios.
Also, while on it, maybe we could get rid of that thingy in next line: margin-bottom:1em auto 1.3em; since it's just wrong syntax (so it's basically it's being ignored by browsers).
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
|
@ludwiczakpawel thanks, you are right. I indeed noticed the padding but wasn't sure why the magic number was there hence I left it alone and altered the height. I fixed as per your suggestion |
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Fix #5682
What type of PR is this? (check all applicable)
Description
The speaker deck tag rendered cuts off horizontal edges due to setting 100% height. I had to remove 63px in order to render slide completely and seems to be fine in all screen sizes, including mobile
Didn't find any tests for this part to update, let me know if I missed it
Related Tickets & Documents
#5682
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?