Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all NA or same value columns with scaling #135

Open
theo-s opened this issue Jun 15, 2023 · 1 comment
Open

Allow all NA or same value columns with scaling #135

theo-s opened this issue Jun 15, 2023 · 1 comment
Assignees

Comments

@theo-s
Copy link
Contributor

theo-s commented Jun 15, 2023

When one of the entries of colSd doesn't exist (constant values, or too many missing values), we we should describe why this is a problem instead of using the current generic error message that just says the colSd doesn't exist.

@edwardwliu edwardwliu self-assigned this Aug 14, 2023
@edwardwliu
Copy link
Collaborator

edwardwliu commented Aug 14, 2023

We should move the scaling logic for calculating column SD and means to the shared C++ layer. In addition, we should make the functional change that columns with all NA or same values do not result in an error. Instead, there should just be a warning logged for the user, such as "Features {a}, {b}, {c} have the same column value so will not be split on when fitting the forest." The training should still complete without errors.

@edwardwliu edwardwliu changed the title More Descriptive Error Messages when colSd doesn't exist Allow all NA or same value columns with scaling Aug 15, 2023
@edwardwliu edwardwliu assigned Ilia-Shutov and unassigned edwardwliu Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants