Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #3

Closed
3TUSK opened this issue Oct 23, 2016 · 3 comments
Closed

Localization #3

3TUSK opened this issue Oct 23, 2016 · 3 comments

Comments

@3TUSK
Copy link
Contributor

3TUSK commented Oct 23, 2016

Sorry for bothering i18n stuff during early development.
Questions to ask:

  1. there is an existed repository for i18n support of binnie. Will we have a separate repository like that?
  2. will a pull request of i18n support be accept, if there is any? assuming there is no breaking change, I can open a pull request of i18n support (Simplified Chinese) right now, as I have already opened one last year.
  3. for last time I checked out binnie, there were still a lot of hard-coded stuff (e.g. name of butterflies, name of flowers, maybe text in all GUIs, cannot recall all of them). Can they be translatable by any chance?
@mezz
Copy link
Member

mezz commented Oct 23, 2016

I have seen a LOT of hard-coded localization so far. It will be a big task to fix.
First priority is getting this mod working, there is still a lot to do.
Getting this mod's localization to be as good as Forestry's is a goal, just not in the short-term.

I don't really like having separated projects for localization, I'm fine with giving you permission to work with this project because I trust you will not edit other things. Is there a big benefit to having the project separated? The Forestry localization gets forgotten sometimes, and changes do not show up in the changelog.

@3TUSK
Copy link
Contributor Author

3TUSK commented Oct 25, 2016

Separating i18n project can makes things clear, as you will have separate lists of coders and translators... Said asie somewhere. IIRC he said so in an issue in CharsetMC/CharsetMC, but I cannot remember which one it is.

Anyhow, I will keep eye on that and won't open pull request until it is almost ready to go. I have already stuck on some flowers' name now...

Sent from 3TUSK's phone

On Oct 23, 2016, at 01:33, mezz notifications@github.com wrote:

I have seen a LOT of hard-coded localization so far. It will be a big task to fix.
First priority is getting this mod working, there is still a lot to do.
Getting this mod's localization to be as good as Forestry's is a goal, just not in the short-term.

I don't really like having separated projects for localization, I'm fine with giving you permission to work with this project because I trust you will not edit other things. Is there a big benefit to having the project separated? The Forestry localization gets forgotten sometimes, and changes do not show up in the changelog.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@3TUSK
Copy link
Contributor Author

3TUSK commented Oct 26, 2016

...and my phone tells me that this email was delivered 3 days after i wrote it. what the...

@3TUSK 3TUSK closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants