Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: it's impossible to disable keyboard shortcuts #245

Closed
FelixFourcolor opened this issue Jun 11, 2023 · 4 comments
Closed

bug: it's impossible to disable keyboard shortcuts #245

FelixFourcolor opened this issue Jun 11, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@FelixFourcolor
Copy link

Instructions: Delete text to unset. Press Return key to accept. Focus out to ignore. Resets to previous value when invalid.

I find that this only works if the text field is non-empty. If the field is empty, after pressing Return and close the setting menu, the shortcut is reset to previous value.

Speculations: Perhaps the delete text to unset part of the logic is not working? Or the press Return key event is only triggered when the field is non-empty? Or empty text is considered invalid so the resets to previous value when invalid rule is invoked?

This is particularly frustrating because the program makes no indications that you have not successfully disable the shortcuts. Instead, it looks as if the shortcuts are unset, but they're actually not, and you only find that out when you try using them or close the setting menu and open it again.

screen.recording.mp4

I suggest until you can fix this bug (or better yet, implement #234), perhaps you could let the fields display their current registered values immediately after they are out of focus, so that the user immediately knows if their modifications fail.

@FelixFourcolor FelixFourcolor added the bug Something isn't working label Jun 11, 2023
@jmmaranan
Copy link
Collaborator

Hi @FelixFourcolor - this is already fixed in main but not released yet. Been busy lately.

@FelixFourcolor
Copy link
Author

I'm sorry, I should've checked first. And thank you for your response.

@jmmaranan
Copy link
Collaborator

I'm sorry, I should've checked first. And thank you for your response.

No worries, and apologies it didn't make it last release. But I think we have enough changes to do a release this week.

@jmmaranan
Copy link
Collaborator

Fixed by #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants