#73 add unmount function #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have been set by the time the child is rendered
…t mount() after rendering children # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Thu Jun 2 10:01:44 2022 -0400 # # On branch 62-incorrect-mount-timing # Changes to be committed: # modified: src/index.ts # modified: src/test/componentMount.tsx # # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Thu Jun 2 10:01:44 2022 -0400 # # interactive rebase in progress; onto 38c00db # Last commands done (4 commands done): # pick 60f7d36 #62: Apply element attrs before rendering children, but call component mount() after rendering children # pick c045be9 #62: denote fix in changelog # Next commands to do (3 remaining commands): # pick 998a563 3.1.2-beta.0 # pick 5f90a8a #62: Fix unit tests after merging in main # You are currently rebasing branch '50-fragment-mount-timing' on '38c00db'. # # Changes to be committed: # modified: CHANGELOG.md # modified: src/index.ts # modified: src/test/componentMount.tsx #
…re all of their children had rendered # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Tue Jul 12 11:03:06 2022 -0400 # # On branch 50-fragment-mount-timing # Changes to be committed: # modified: CHANGELOG.md # modified: src/index.ts # new file: src/test/fragmentMountTiming.tsx # modified: src/test/test.ts #
…ler kicks an update # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Sat Aug 6 19:20:31 2022 -0400 # # On branch 70-support-recursive-mount # Changes to be committed: # modified: CHANGELOG.md # modified: src/index.ts # modified: src/test/componentMount.tsx # # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Sat Aug 6 19:20:31 2022 -0400 # # On branch 70-support-recursive-mount # Changes to be committed: # modified: CHANGELOG.md # modified: src/index.ts # modified: src/test/componentMount.tsx # # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # Date: Sat Aug 6 19:20:31 2022 -0400 # # On branch 70-support-recursive-mount # Changes to be committed: # modified: CHANGELOG.md # modified: src/index.ts # modified: src/test/componentMount.tsx #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also branched off of the #65 PR, because it too meddles with mount/unmount code.
The PR looks bigger than it really is because I lifted some code out of conditionals and changed it to do early returns instead.
Basically we're just adding a new
forgo.unmount()method, migrating the unmount tests to the new scaffolding, and adding the appropriate test case.