Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#73 add unmount function #74

Merged
merged 10 commits into from
Aug 29, 2022
Merged

#73 add unmount function #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed712d0
#62: Added a failing test asserting that the parent node's attributes…
spiffytech Jun 1, 2022
6d9e44e
#62: Don't call syncStateAndProps() until children have been rendered
spiffytech Jun 1, 2022
26edbbd
#62: Apply element attrs before rendering children, but call componen…
spiffytech Jun 2, 2022
34dcb78
3.1.2-beta.0
spiffytech Jun 18, 2022
51065cc
#62: Fix unit tests after merging in main
spiffytech Jul 11, 2022
df44487
#50: Fix fragment-based components having their mount event fire befo…
spiffytech Jul 12, 2022
dba7dcd
Merge branch 'main' into 50-fragment-mount-timing
spiffytech Aug 5, 2022
b59ef0a
3.2.1
spiffytech Aug 5, 2022
2f2d6bb
#70: Don't call the mount lifecycle handler twice when the mount hand…
spiffytech Aug 6, 2022
1190af6
#73: Allow a user to explicitly unmount a Forgo app from the outside
spiffytech Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# 3.2.1

- Fix #50: Components that returned a fragment saw their `mount` lifecycle
method called after the first child element had been created instead of after
the render had completed.
- Fix a bug where calling `component.update()` during a mount lifecycle handler
resulted in the component recursively mounting ad infinitum.

# 3.2.0

- #59: Forgo's legacy component syntax (component syntax used through v3.1.1)
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "forgo",
"version": "3.2.0",
"version": "3.2.1",
"main": "./dist/index.js",
"type": "module",
"author": "Jeswin Kumar<jeswinpk@agilehead.com>",
Expand Down
Loading