Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pull without showing modal window #43

Closed
cybernetics opened this issue Nov 16, 2018 · 7 comments
Closed

Ability to pull without showing modal window #43

cybernetics opened this issue Nov 16, 2018 · 7 comments
Milestone

Comments

@cybernetics
Copy link

everytime I click pull, it'll popup a modal window. I don't want to see that popup every time I pull. it's good for 1st time. pull command should remember my options selected 1st time and keep using them as long as I do not want to make any changes OR just pull currently checked-out branch. please provide setting to change it on-demand.

@DanPristupov
Copy link
Contributor

DanPristupov commented Nov 24, 2018

We need to be careful there.

Pull = fetch + merge. Merge is a quite a dangerous operation and it's better to always show the prompt dialog.

However, I can introduce silent mode on Ctrl+Click on the Pull toolbar button, which will work only if the active branch has an upstream (i.e. corresponding remote tracking branch). Though the 'Stash and reapply' dialog will appear anyway if working directory is not clean.

@cybernetics
Copy link
Author

but I'll prefer KB shortcut without seeing popup all the time. you can still introduce Ctrl+Click behaviour as you mentioned for people who prefer mouse clicking.

@Otiel
Copy link

Otiel commented Apr 25, 2019

I only use the keyboard shortcut but prefer to see the window every time I pull.

@cybernetics
Copy link
Author

cybernetics commented Apr 27, 2019

I don't. it slows me down. I know where I'm pulling from. so I'll prefer for more frequent PULLs, we should have an option to disable the popup. if you want to pull from different upstream you can go back to setting and change the behavior. this is what I wished for. but it's not implemented.

@Otiel
Copy link

Otiel commented Jun 17, 2019

I think the correct way to do this would be to add a checkbox "☑ Don't ask me again" on the Pull dialog, with the possibility to revert this change in Preferences.

The default behavior should stay as it is today, namely showing the dialog. But an option to hide it would be good.

@DanPristupov DanPristupov changed the title disable pull modal window Ability to pull without showing modal window Jun 21, 2019
@DanPristupov DanPristupov added this to the 1.35 milestone Jun 21, 2019
@DanPristupov
Copy link
Contributor

We added ability to fetch/pull/push without a dialog in 1.35.

You need to hold Ctrl when click on the icon, or use the Ctrl+Alt+Shift+L shortcut (you can see more shortcuts there #333).

@decadence
Copy link

@DanPristupov great addition, it's very handy. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants