Skip to content

Commit

Permalink
Homepage improvements (closes #29, #64, #146, #171) (#184)
Browse files Browse the repository at this point in the history
Some improvements to the Homescreen!

* Do not show collections placeholder in home screen on a clean install and subsequently as well. 
* Increase the limit for top sites to 160
* Show 20 top sites on the screen at a time, before pagination occurs.
  • Loading branch information
abhijitvalluri committed Sep 29, 2020
1 parent e04fbe2 commit fce3d11
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class HomeFragment : Fragment() {
)
).getTip()
},
showCollectionPlaceholder = components.settings.showCollectionsPlaceholderOnHome
showCollectionPlaceholder = false
)
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ class TopSitePagerViewHolder(
companion object {
const val LAYOUT_ID = R.layout.component_top_sites_pager
const val TOP_SITES_MAX_PAGE_SIZE = 2
const val TOP_SITES_PER_PAGE = 8
const val TOP_SITES_PER_PAGE = 20
}
}
2 changes: 1 addition & 1 deletion app/src/main/java/org/mozilla/fenix/utils/Settings.kt
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ private const val AUTOPLAY_USER_SETTING = "AUTOPLAY_USER_SETTING"
class Settings(private val appContext: Context) : PreferencesHolder {

companion object {
const val topSitesMaxCount = 16
const val topSitesMaxCount = 160
const val FENIX_PREFERENCES = "fenix_preferences"

private const val BLOCKED_INT = 0
Expand Down

0 comments on commit fce3d11

Please sign in to comment.