Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]enable more than 8 topsites on home page #29

Closed
ale82to opened this issue Aug 28, 2020 · 3 comments · Fixed by #184
Closed

[Bug]enable more than 8 topsites on home page #29

ale82to opened this issue Aug 28, 2020 · 3 comments · Fixed by #184
Assignees
@abhijitvalluri
Labels
affects-upstream Issues that also affect Mozilla Firefox (Fenix) builds enhancement New feature or request help wanted Extra attention is needed

Comments

@ale82to
Copy link

ale82to commented Aug 28, 2020

please re - enable the ability to have as many topsites as we need on home page like previous build, please!
@ale82to
Copy link
Author

ale82to commented Aug 28, 2020

maybe look at ...n/java/org/mozilla/fenix/home/sessioncontrol/viewholders/topsites/TopSitesPagerAdapter.kt

or

gabrielluong@7e1624e

@ale82to
Copy link
Author

ale82to commented Aug 28, 2020

mozilla-mobile#8312

@interfect interfect added affects-upstream Issues that also affect Mozilla Firefox (Fenix) builds enhancement New feature or request help wanted Extra attention is needed labels Aug 29, 2020
@ale82to
Copy link
Author

ale82to commented Aug 30, 2020

I succeeded in editing smali2folder with apktool (on a phone) I can have 16 top sites at max, better than nothing
this is the file to edit
TopSitesPagerAdapter.smali
(const/16 v0, 0x.. )

@abhijitvalluri abhijitvalluri mentioned this issue Sep 29, 2020
Merged
3 tasks
@abhijitvalluri abhijitvalluri self-assigned this Sep 29, 2020
abhijitvalluri added a commit that referenced this issue Sep 29, 2020
@abhijitvalluri
Homepage improvements (closes #29, #64, #146, #171) (#184)
fce3d11 
Some improvements to the Homescreen!

* Do not show collections placeholder in home screen on a clean install and subsequently as well. 
* Increase the limit for top sites to 160
* Show 20 top sites on the screen at a time, before pagination occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhijitvalluri abhijitvalluri

Labels
affects-upstream Issues that also affect Mozilla Firefox (Fenix) builds enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Homepage improvements (closes #29, #64, #146, #171) abhijitvalluri/firefox2
3 participants
@interfect @ale82to @abhijitvalluri