Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Top Sites (optionally) more like Fennec: 5 icons per row, 12-15 on screen #146

Closed
Leviafan83 opened this issue Sep 22, 2020 · 8 comments · Fixed by #184
Closed

Make Top Sites (optionally) more like Fennec: 5 icons per row, 12-15 on screen #146

Leviafan83 opened this issue Sep 22, 2020 · 8 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Leviafan83
Copy link

make the top sites as in the old version

Screenshot_20200921-152812

@abhijitvalluri abhijitvalluri added enhancement New feature or request question Further information is requested and removed needs:triage labels Sep 22, 2020
@abhijitvalluri
Copy link
Collaborator

What exactly is the old behaviour that you want to replicate?

@Leviafan83
Copy link
Author

all tabs on one screen. or at least 12 - 15 tabs on one screen.

@sheikh-azharuddin
Copy link

all tabs on one screen. or at least 12 - 15 tabs on one screen.

And 5 icons per row

@ale82to
Copy link

ale82to commented Sep 22, 2020

I d love that too and already opened a bug /request for it

@ale82to
Copy link

ale82to commented Sep 22, 2020

with smali editing i can get at max 16 top sites in one page to get 5 icons per row i must edit res /layout too.
I d love more than 16 topsites anyway.

@interfect
Copy link
Collaborator

How does this relate to #135 to make the icons bigger?

@interfect interfect added good first issue Good for newcomers help wanted Extra attention is needed and removed question Further information is requested labels Sep 23, 2020
@interfect interfect changed the title Top sites old Make Top Sites (optionally) more like Fennec: 5 icons per row, 12-15 on screen Sep 23, 2020
@CharmCityCrab
Copy link

CharmCityCrab commented Sep 23, 2020

I prefer four icons to a row because of the trend towards smartphones that are longer but narrower than their predecessors.

However, I do agree that an option to do something with all that blank space would be nice. Adding extra rows of top sites (as suggested above) would be an improvement over the current behavior in that respect whether the icons are 4 to a row or 5 to a row.

Another approach would be that users could perhaps choose between several categories like "top sites", "bookmarks", "history", "recently closed tabs", "collections", and such, either having an option screen where the user picks one type of thing to fill out the whole screen (If enough of that type of content has been generated by the user's personal browser use) or where a user selects a set number of modules based on those categories, probably two, and each module would take up half the screen (one on top of the other) minus the space allotted for the browser name at the top and potentially the browser logo to the side of the name on the same line.

In practice, we might see one user's screen list "Iceraven" , followed by a first box with "top sites" and a second box with "most recent browser history" underneath the first box. Another user might choose "bookmarks" for the first box and "recently closed tabs" for the second box. In this way, Iceraven could give the user control over the page (At least within the constraints of having to choose from a necessarily limited number of category options), apart from the name/logo at the top, which is good branding, and the page itself would be sure to fill up with options each user finds personally useful and not be wasted blank space.

Just doing it the original poster's way is at least an improvement over the status quo, though.

One big thing to avoid with whatever system we embrace is not just having a bunch of blank space as the only substitute if the user disables "collections", a somewhat controversial feature that we can probably expect a fair amount of opt-outs of.

@sheikh-azharuddin
Copy link

How about android style quick panel customization where user can define number of rows and number of columns...
Maybe we can use the same style for top sites.

@abhijitvalluri abhijitvalluri self-assigned this Sep 29, 2020
abhijitvalluri added a commit that referenced this issue Sep 29, 2020
Some improvements to the Homescreen!

* Do not show collections placeholder in home screen on a clean install and subsequently as well. 
* Increase the limit for top sites to 160
* Show 20 top sites on the screen at a time, before pagination occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants