Use templating services #1423
Use templating services #1423
Conversation
|
@tijsverkoyen @Thijzer do you have some time to look into this? IMO, it can be merged in the 3.10 branch. (Some parts could still be a little cleaner, but everything works and we can further refactor later too). I'd like to see this merged soon, because it changes a lot of stuff, and further PR's to the 3.10 branch should depend on this (to avoid merge conflicts) |
|
Hi @WouterSioen, thanks for picking it up where I left off. I can take a look tomorrow evening, if that's ok.. |
|
@Thijzer that would be very nice :) |
|
twig file render errors here are the routes I only checked the backend minimal install modules... php errors Frontend voila, |
|
Thanks for checking it, I'll look into it! |
- decoupling - less duplication - added more modifiers Form - always instanciated - workaround for extends forms without initial form tag
Using two forms on one page didn't work anymore and the form names were incorrect. (should be in camelcase)
This will help us debug some issues in the tests on travis ci.
This should also fix some tests in the installer.
If we give the inserted engine the right properties and attach the loader to it using the chain loader, we can use the same environment to render every template.
No need to parse the positions and the forms into the navigation.
We don't want any other places to call this rather dirty method.
Note that the datagrid templates are kept, because they are still parsed using spoontemplate.
WouterSioen
force-pushed
the
use-templating-services
branch
from
44ef538
to
f2d4265
Compare
|
@vytenizs if you want to help, it would be awesome if you could test this branch (and do some PR's if needed). I want to get this one merged asap, to be able to implement the new design on twig instead of SpoonTemplate. |
|
Ok ill merge this on my new project and test it ASAP. |
|
great! You might still get a lot of errors though ;) |
The password field does not have a default value, so we should add it during insert.
This is already done using composer.
|
included in #1447 |
Follow up on #1351 (since @Thijzer doesn't have a lot of time anymore)
Changes:
new TwigTemplate()ob_startandob_get_cleanAll feedback is welcome on this!