Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagetree update + yarn [WIP] #2157

Closed
wants to merge 9 commits into from

Conversation

jessedobbelaere
Copy link
Member

Type

  • Enhancement
  • Feature

Resolves the following issues

Fixes #1999

Pull request description

We used a very very old version of jsTree from 2009. So this needs to be updated urgently to the latest version + added to Yarn.

  • I tried to follow the original look & feel of the Fork CMS page tree. Because we cannot use the jQuery pageroller theme anymore, I chose to use a jstree bootstrap theme and tweak it in our own sass code until it looks again like the old Fork CMS pagetree (with a few optimizations).
  • Icons are from fontawesome now, instead of our old fork_icons.png sprite.
  • Was playing with the jsTree search plugin that ships by default in jsTree and tried integrating it. End result looks cool, might be handy to include because it makes bigger websites more maintainable if you can find your page to edit fast.
  • Not really related to this ticket, but we have a typeahead.bundle.min.js in our /js folder, but nowhere to be seen in package.json or gulpfile. Added it back because somebody might regenerate the js folder and delete the typeahead file by accident which makes search frontend unusable.

Video

http://d.pr/v/nrbp2

Still need to handle the drag and drop callbacks and test thorough and do bugfixes...

@carakas carakas added this to the 5.1.0 milestone Aug 4, 2017
@carakas carakas changed the base branch from 5.0.0-dev to master August 4, 2017 09:43
@jeroendesloovere
Copy link
Member

@jessedobbelaere does your PR also contains pagetree-code for the MediaLibrary module?

@carakas
Copy link
Member

carakas commented Aug 31, 2017

@jessedobbelaere any update on this?

1 similar comment
@carakas
Copy link
Member

carakas commented Sep 25, 2017

@jessedobbelaere any update on this?

@carakas carakas changed the base branch from master to 5.1.0-dev September 29, 2017 12:45
@jeroendesloovere
Copy link
Member

Hi @jessedobbelaere, what's you status?

@carakas carakas modified the milestones: 5.1.0, 5.2.0 Jan 24, 2018
@carakas carakas changed the base branch from 5.1.0-dev to master January 24, 2018 13:46
@StijnVrolijk StijnVrolijk modified the milestones: 5.2.0, 5.3.0 Feb 9, 2018
@jeroendesloovere
Copy link
Member

@forkcms/core-contributors any frontend dev willing to finish this integration?
Would be awesome, since then we rely on external js and not core js.

@carakas
Copy link
Member

carakas commented Mar 12, 2018

@jessedobbelaere any update on this?

@jessedobbelaere
Copy link
Member Author

jessedobbelaere commented Mar 12, 2018

I looked at it this weekend but most of the time was used to fix merge conflicts (actually just re-applied my changes on the latest develop). Will try to finish it

@carakas
Copy link
Member

carakas commented Mar 12, 2018

awesome

@carakas carakas modified the milestones: 5.3.0, 5.4.0 May 28, 2018
@jeroendesloovere
Copy link
Member

Anybody willing to pick this issue up and fix it?
@Katrienvh, @mathiashelin ?

@carakas
Copy link
Member

carakas commented Jul 2, 2018

We'll probably wait for this till the backend is switched to BS4, unless somebody else wants to do this sooner

@carakas carakas modified the milestones: 5.4.0, 6.0.0 Jul 2, 2018
@carakas
Copy link
Member

carakas commented Oct 29, 2019

This will be done in #2403

@carakas carakas closed this Oct 29, 2019
@carakas carakas removed this from the 6.0.0 milestone Oct 29, 2019
@jessedobbelaere jessedobbelaere deleted the yarn-jstree branch July 19, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For the Pages module: yarn add jstree and yarn add jquery.cookie
4 participants