Require pimple not only as a dev dependency but also production since ckfinder needs it #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ckfinder needs it
|
@carakas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @WouterSioen, @jeroendesloovere and @tijsverkoyen to be potential reviewers. |
WouterSioen
approved these changes
Sep 1, 2017
StijnVrolijk
approved these changes
Sep 1, 2017
|
@WouterSioen either one of the packages requires pimple as a dev requirement incorrectly or @carakas made a booboo. I'm guessing the first since the pimple package was in fact in the lock file. |
|
still a booboo :D |
|
@WouterSioen nobody is perfect :) it is indeed something I didn't notice, but I'm also the one fixing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Pimple was added as dev dependency while we also need it in production for ckfinder