Fix check if the email or displayname exists without excluding a profile #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the wrong fix to me, you should build the query accordingly (with or without the id check). |
|
I don't get what the bug is, and why we should pass 0 instead of null? |
carakas
force-pushed
the
fix-forgot-password
branch
from
6a5ce1c
to
7b52960
Compare
not all mysql servers support this caused the check to see if the email address was valid to fail sometimes
|
@jonasdekeukelaere @tijsverkoyen true, it was a bit of a quickfix, improved it in 7b52960 |
jonasdekeukelaere
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
not all mysql servers support this caused the check to see if the email address or display name was valid to fail sometimes