Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional blocks for MediaLibrary module #2309

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Add additional blocks for MediaLibrary module #2309

merged 2 commits into from
Oct 16, 2017

Conversation

jeroendesloovere
Copy link
Member

@jeroendesloovere jeroendesloovere commented Oct 10, 2017 •
edited
Loading

Type

  • Enhancement

Pull request description

  • Added missing "heading/footer" blocks in the "MediaLibrary module" templates.
  • In Lightbox.html.twig, divided into block_body and lightbox_template.

@jeroendesloovere jeroendesloovere added this to the 5.1.0 milestone Oct 10, 2017
@carakas
Copy link
Member

carakas commented Oct 10, 2017

why all different pull request? Wouldn't it be better to have one and not a new pr for each commit

@carakas carakas merged commit abec2f2 into forkcms:5.1.0-dev Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carakas carakas carakas approved these changes

Assignees
No one assigned
Labels
Enhancement Media Library
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroendesloovere @carakas