The tags should be case insensitive unique #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
array_unique takes the case into account, adding a tag Ichtus and ichtus would result in a 500 error since the database would see it as a double entry but the php as separate entries
WouterSioen
reviewed
Mar 7, 2018
|
@WouterSioen I've just tested it on the demo
When saving this it will give a 500 error |
|
Bugfix it is, let's merge this and put it in the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
array_unique takes the case into account, adding a tag Ichtus and ichtus would result in a 500 error since the database would see it as a double entry but the php as separate entries