New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix related tags type error #2664

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@bart-webleads
Copy link
Contributor

bart-webleads commented Oct 22, 2018

Type

  • Critical bugfix

Pull request description

The related tags widget did not work, because of an error.
Type error: Argument 2 passed to Frontend\Modules\Tags\Engine\Model::getForItem() must be of the type integer, null given, called in src/Frontend/Modules/Tags/Widgets/Related.php on line 152

The getIdForTags function returns an id and not a record as assumed in the related widget code.
Also removed useless comments in this function.

Fix type error
The related tags widget did not work, because of an error.
Type error: Argument 2 passed to Frontend\Modules\Tags\Engine\Model::getForItem() must be of the type integer, null given, called in src/Frontend/Modules/Tags/Widgets/Related.php on line 152
@carakas

carakas approved these changes Nov 5, 2018

@carakas carakas added this to the 5.4.2 milestone Nov 5, 2018

@carakas carakas merged commit 35cf5a7 into forkcms:master Nov 5, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@carakas

This comment has been minimized.

Copy link
Member

carakas commented Nov 5, 2018

maybe try removing the comments in a separate commit the next time, now it was hard to find the difference @bart-webleads but thanks for the fix 😄

@carakas carakas modified the milestones: 5.4.2, 5.5.0 Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment