Fix related tags type error #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The related tags widget did not work, because of an error. Type error: Argument 2 passed to Frontend\Modules\Tags\Engine\Model::getForItem() must be of the type integer, null given, called in src/Frontend/Modules/Tags/Widgets/Related.php on line 152
carakas
approved these changes
Nov 5, 2018
|
maybe try removing the comments in a separate commit the next time, now it was hard to find the difference @bart-webleads but thanks for the fix 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
The related tags widget did not work, because of an error.
Type error: Argument 2 passed to Frontend\Modules\Tags\Engine\Model::getForItem() must be of the type integer, null given, called in src/Frontend/Modules/Tags/Widgets/Related.php on line 152
The getIdForTags function returns an id and not a record as assumed in the related widget code.
Also removed useless comments in this function.