Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2681 change image preview #2695

Merged
merged 8 commits into from
Dec 20, 2018
Merged

2681 change image preview #2695

merged 8 commits into from
Dec 20, 2018

Commits on Dec 19, 2018

  1. Use a fork image specific data attribute on the imageType

    Verstraete Kevin committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    276043d View commit details
    Browse the repository at this point in the history

  2. Read the uploaded image data url and show a preview of the image

    Verstraete Kevin committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    c97e449 View commit details
    Browse the repository at this point in the history

  3. Add data attribute to the upload field to support image preview when … 

    …editting a blog post
    Verstraete Kevin committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    988c5aa View commit details
    Browse the repository at this point in the history

  4. Allow image preview on page edit 

    Add pane and alternative image class to the image preview function
    Verstraete Kevin committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    2163031 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. Add data attributes to identify an image preview field

    Verstraete Kevin committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    094b909 View commit details
    Browse the repository at this point in the history

  2. Match the imageField data-id with the same image preview data-id for … 

    …efficient field targetting
    Verstraete Kevin committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    087fe9e View commit details
    Browse the repository at this point in the history

  3. Add data attributes to the image field of the page and blog module 

    With these data attributes we can use the image preview function
    Verstraete Kevin committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    215b5d0 View commit details
    Browse the repository at this point in the history

  4. Add the previewImage function to the frontend javascript file

    Verstraete Kevin committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    dfae060 View commit details
    Browse the repository at this point in the history