Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Change exp to a peerDependency #23

Closed
motiz88 opened this issue Feb 24, 2018 · 1 comment · Fixed by #27
Closed

Change exp to a peerDependency #23

motiz88 opened this issue Feb 24, 2018 · 1 comment · Fixed by #27
Milestone

Comments

@motiz88
Copy link

motiz88 commented Feb 24, 2018

appr's current behaviour is to prefer <app>/node_modules/exp over <app>/node_modules/appr/node_modules/exp - a duplication that exists if the app has a newer or incompatible version of exp as a dependency.

This is useful behaviour - e.g. to synchronise the version of exp between appr and any custom CI scripts used by the app. Moving exp to peerDependencies would simply codify it and make it explicit.

@jevakallio jevakallio added this to the 2.0 milestone Mar 6, 2018
@jevakallio
Copy link
Contributor

Thanks @motiz88. Good shout, let's do this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants