Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-3703: Fixes an issue where NestedData components with modal view do not render values inside Layout components in modal preview table #5558

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

alexandraRamanenka
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-3703

Description

NestedDataComponent was not iterating through layout components to render the values of the components inside them. Also, getComponents method was checking only in rowIndex is undefined, but it also could be null because inside everyComponent method it is set to null if not provided.

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

I added automated tests to cover [all/the following] cases, including ...

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…do not render values inside Layout components in modal preview table
@alexandraRamanenka alexandraRamanenka force-pushed the fio-3703-nested-data-components-modal-preview branch from a642104 to 97fe965 Compare April 8, 2024 14:03
@alexandraRamanenka alexandraRamanenka force-pushed the fio-3703-nested-data-components-modal-preview branch from 97fe965 to 61bf725 Compare April 9, 2024 08:44
@TanyaGashtold TanyaGashtold merged commit b27d9d2 into master Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants