Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

multiCheckbox defaults to required #37

Closed
qinche opened this issue Jul 13, 2015 · 5 comments
Closed

multiCheckbox defaults to required #37

qinche opened this issue Jul 13, 2015 · 5 comments

Comments

@qinche
Copy link

qinche commented Jul 13, 2015

Whenever I check and then uncheck one of the checkboxes, the form will be set to invalid because required: true, even though I did not specify that in temaplateOptions. I believe this is a bug that needs to be fixed.

@kentcdodds
Copy link
Member

Could you show an example? http://issue.angular-formly.com/

@qinche
Copy link
Author

qinche commented Jul 13, 2015

http://jsbin.com/niyoxe/edit?html,js,output here it is, modified from a previous issue.

@kentcdodds
Copy link
Member

Ah, I see. You're right. I'm not sure what the issue is right off. I'll try to get to it soon, but I can't promise anything. If you (or anyone watching) could help to identify why this is happening (and even submit a PR) that would help a great deal.

@kentcdodds
Copy link
Member

I'll release the fix as soon as I get to my laptop.

@kentcdodds
Copy link
Member

Released as 5.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants