Improve sgx-isa usability, add test for local attestation #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrogb
force-pushed
the
jb/local-attestation
branch
6 times, most recently
from
257cae4
to
f2bf42b
Compare
jethrogb
force-pushed
the
jb/local-attestation
branch
from
f2bf42b
to
c5598ee
Compare
jethrogb
commented
Aug 16, 2019
sgx-tests/tests/report_mac.rs
Outdated
|
|
||
| let mut mac_out = [0u8; 16]; | ||
| Cipher::new(CipherId::Aes, CipherMode::ECB, 128).unwrap() | ||
| .cmac(&key, report.mac_data(), &mut mac_out).unwrap(); |
There was a problem hiding this comment.
this should use the verify function
jethrogb
force-pushed
the
jb/local-attestation
branch
2 times, most recently
from
0d0bebb
to
3a6f367
Compare
|
Would it be worth it to introduce |
|
bors r+ |
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.