Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential expression conflicts #8

Open
rsenden opened this issue Mar 12, 2020 · 0 comments
Open

Potential expression conflicts #8

rsenden opened this issue Mar 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rsenden
Copy link
Contributor

rsenden commented Mar 12, 2020

Configuration files may contain ${...} placeholders to reference environment variables/system properties. However, some configuration properties (*Expression) may define expressions that also contain ${...} placeholders. These template placeholders should not be evaluated when the configuration file is loaded, but rather should be passed as-is to the relevant code,

Spring seems to pass ${...} placeholders as-is if the placeholder cannot be resolved as an environment variable or system property, which fits our use cases.

However, potentially this could result in conflicts, for example if an environment variable is defined with the same name as used in a template expression.

It would be much better if we would use different syntax for placeholders resolved at configuration time, and placeholders resolved at some later time.

@rsenden rsenden added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant