1.29 and go 1.18 base + #566 (round robin dns) + #564 (revamp of build through go install module buildinfo) #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 82ac1bc and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
========================================
- Coverage 87.4% 87.4% -0.0%
========================================
Files 26 26
Lines 3602 3610 +8
========================================
+ Hits 3148 3154 +6
- Misses 303 304 +1
- Partials 151 152 +1
Continue to review full report at Codecov.
|
…ake advantage of it (#564) * prep for 1.29 * adding new HTTPServerWithHandler to use in proxy * tag_name on upload needs to be trailing part * switch to go 1.18.2 - in prep for #561 * use debug.ReadBuildInfo() instead of linker time set version info * update release readme * fix windows build path * fix the release-test case by having a build vs install mode still and control through MODE= arg * allow the OFFICIAL_DIR to be determined from OFFICIAL_BIN so brew command doesn't need to change * removed DATA_DIR change support as it's not used, simplify further * Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes (#566) * round robin fnet.resolve. fixes #557 * fix #567 only show actual threads for dns etc, #458 flag to pick ip4, ip6 or both resolve * add connect timeout to fast client. fixes #568 * use ip4 as default to avoid a bunch of test failures and failure in ip4 environment with Round Robin DNS
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
fnet/network.go
Outdated
| @@ -59,6 +63,12 @@ var ( | |||
| MaxPayloadSize = 256 * KILOBYTE | |||
| // Payload that is returned during echo call. | |||
| Payload []byte | |||
| // Atomically incremented counter for dns resolution. | |||
| dnsRoundRobin uint32 = 0xffffffff // we want the first one, after increment to be 0 | |||
| // IP types to resolve. With round robin you are likely to get ipv6 which may not work | |||
There was a problem hiding this comment.
comment on exported var FlagResolveIPType should be of the form "FlagResolveIPType ..."
| @@ -49,11 +46,23 @@ func Long() string { | |||
| return longVersion | |||
| } | |||
|
|
|||
| func Full() string { | |||
There was a problem hiding this comment.
exported function Full should have comment or be unexported
ldemailly
changed the title
ldemailly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge train with #564, #566