Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes #566

Merged
merged 5 commits into from May 13, 2022

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented May 13, 2022

fixes #557

go run . load -c 15 -n 30 ...

IP addresses distribution:
10.144.94.186:443: 5
10.144.105.0:443: 5
10.144.68.177:443: 5

also fixes #567 (only show actual threads for dns) and fixes #458 (option to pick ipv6/v4/both dns resolution) and fixes #568 (connect timeout in fast client)

@ldemailly ldemailly changed the base branch from master to buildinfo_version May 13, 2022 20:06
@codeclimate
Copy link

codeclimate bot commented May 13, 2022

Code Climate has analyzed commit 5839aff and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@ldemailly ldemailly changed the title Rr dns Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #566 (f289127) into buildinfo_version (48c74c1) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@                Coverage Diff                @@
##           buildinfo_version    #566   +/-   ##
=================================================
  Coverage               87.3%   87.4%           
=================================================
  Files                     26      26           
  Lines                   3604    3610    +6     
=================================================
+ Hits                    3148    3154    +6     
  Misses                   304     304           
  Partials                 152     152           
Impacted Files Coverage Δ
fhttp/http_client.go 83.7% <100.0%> (+<0.1%) ⬆️
fhttp/httprunner.go 85.7% <100.0%> (+0.1%) ⬆️
fnet/network.go 88.7% <100.0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c74c1...f289127. Read the comment docs.

@ldemailly ldemailly merged commit f3686a7 into buildinfo_version May 13, 2022
@ldemailly ldemailly deleted the rr_dns branch May 13, 2022 21:56
ldemailly added a commit that referenced this pull request May 13, 2022
…ake advantage of it (#564)

* prep for 1.29

* adding new HTTPServerWithHandler to use in proxy

* tag_name on upload needs to be trailing part

* switch to go 1.18.2 - in prep for #561

* use debug.ReadBuildInfo() instead of linker time set version info

* update release readme

* fix windows build path

* fix the release-test case by having a build vs install mode still and control through MODE= arg

* allow the OFFICIAL_DIR to be determined from OFFICIAL_BIN so brew command doesn't need to change

* removed DATA_DIR change support as it's not used, simplify further

* Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes (#566)

* round robin fnet.resolve. fixes #557

* fix #567 only show actual threads for dns etc, #458 flag to pick ip4, ip6 or both resolve

* add connect timeout to fast client. fixes #568

* use ip4 as default to avoid a bunch of test failures and failure in ip4 environment with Round Robin DNS
ldemailly added a commit that referenced this pull request May 13, 2022
…d through go install module buildinfo) (#560)

* prep for 1.29

* adding new HTTPServerWithHandler to use in proxy

* tag_name on upload needs to be trailing part

* switch to go 1.18.2 - in prep for #561

* Buildinfo based version and official builds through `go install` to take advantage of it (#564)

* adding new HTTPServerWithHandler to use in proxy

* tag_name on upload needs to be trailing part

* switch to go 1.18.2 - in prep for #561

* use debug.ReadBuildInfo() instead of linker time set version info

* update release readme

* fix windows build path

* fix the release-test case by having a build vs install mode still and control through MODE= arg

* allow the OFFICIAL_DIR to be determined from OFFICIAL_BIN so brew command doesn't need to change

* removed DATA_DIR change support as it's not used, simplify further

* Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes (#566)

* round robin fnet.resolve. fixes #557

* fix #567 only show actual threads for dns etc, #458 flag to pick ip4, ip6 or both resolve

* add connect timeout to fast client. fixes #568

* use ip4 as default to avoid a bunch of test failures and failure in ip4 environment with Round Robin DNS

* code climate updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round robin DNS resolver by default
2 participants