Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildinfo based version and official builds through go install to take advantage of it #564

Merged
merged 23 commits into from May 13, 2022

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented May 13, 2022

$ docker run fortio/fortio:1.29.0-pre12 version
v1.29.0-pre12 h1:Ud8vqkyAvi4nRPmyBz8chZR8JqhDTLP4el4xgmiB8iY= go1.18.2 arm64 linux
go	go1.18.2
path	fortio.org/fortio
mod	fortio.org/fortio	v1.29.0-pre12	h1:Ud8vqkyAvi4nRPmyBz8chZR8JqhDTLP4el4xgmiB8iY=
dep	github.com/fsnotify/fsnotify	v1.5.4	h1:jRbGcIw6P2Meqdwuo0H1p6JVLbL5DHKAKlYndzMwVZI=
dep	github.com/golang/protobuf	v1.5.2	h1:ROPKBNFfQgOUMifHyP+KYbvpjbdoFNs+aK7DXlji0Tw=
dep	github.com/google/uuid	v1.3.0	h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
dep	golang.org/x/net	v0.0.0-20220425223048-2871e0cb64e4	h1:HVyaeDAYux4pnY+D/SiwmLOR36ewZ4iGQIIrtnuCjFA=
dep	golang.org/x/sys	v0.0.0-20220412211240-33da011f77ad	h1:ntjMns5wyP/fN65tdBD4g8J5w8n015+iIIs9rtjXkY0=
dep	golang.org/x/text	v0.3.7	h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
dep	google.golang.org/genproto	v0.0.0-20200526211855-cb27e3aa2013	h1:+kGHl1aib/qcwaRi1CbqBZ1rk19r85MNUf8HaBghugY=
dep	google.golang.org/grpc	v1.46.0	h1:oCjezcn6g6A75TGoKYBPgKmVBLexhYLM6MebdrPApP8=
dep	google.golang.org/protobuf	v1.27.1	h1:SnqbnDw1V7RiZcXPx5MEeqPv2s79L9i7BJUlG/+RurQ=
build	-compiler=gc
build	-ldflags="-s -X main.defaultDataDir=."
build	CGO_ENABLED=0
build	GOARCH=arm64
build	GOOS=linux

fixes #561 and #551

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #564 (48c74c1) into 1_29 (1673173) will not change coverage.
The diff coverage is n/a.

❗ Current head 48c74c1 differs from pull request most recent head f3686a7. Consider uploading reports for the commit f3686a7 to get more accurate results

@@          Coverage Diff          @@
##            1_29    #564   +/-   ##
=====================================
  Coverage   87.3%   87.3%           
=====================================
  Files         26      26           
  Lines       3604    3604           
=====================================
  Hits        3148    3148           
  Misses       304     304           
  Partials     152     152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1673173...f3686a7. Read the comment docs.

…fixes (#566)

* round robin fnet.resolve. fixes #557

* fix #567 only show actual threads for dns etc, #458 flag to pick ip4, ip6 or both resolve

* add connect timeout to fast client. fixes #568

* use ip4 as default to avoid a bunch of test failures and failure in ip4 environment with Round Robin DNS
@ldemailly ldemailly merged commit 9d5567d into 1_29 May 13, 2022
@ldemailly ldemailly deleted the buildinfo_version branch May 13, 2022 21:57
ldemailly added a commit that referenced this pull request May 13, 2022
…d through go install module buildinfo) (#560)

* prep for 1.29

* adding new HTTPServerWithHandler to use in proxy

* tag_name on upload needs to be trailing part

* switch to go 1.18.2 - in prep for #561

* Buildinfo based version and official builds through `go install` to take advantage of it (#564)

* adding new HTTPServerWithHandler to use in proxy

* tag_name on upload needs to be trailing part

* switch to go 1.18.2 - in prep for #561

* use debug.ReadBuildInfo() instead of linker time set version info

* update release readme

* fix windows build path

* fix the release-test case by having a build vs install mode still and control through MODE= arg

* allow the OFFICIAL_DIR to be determined from OFFICIAL_BIN so brew command doesn't need to change

* removed DATA_DIR change support as it's not used, simplify further

* Round robin dns, option to resolve ipv4/ipv6/both, timeout and other fixes (#566)

* round robin fnet.resolve. fixes #557

* fix #567 only show actual threads for dns etc, #458 flag to pick ip4, ip6 or both resolve

* add connect timeout to fast client. fixes #568

* use ip4 as default to avoid a bunch of test failures and failure in ip4 environment with Round Robin DNS

* code climate updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant