Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Next release? #799

Closed
noraj opened this issue Mar 19, 2020 · 3 comments
Closed

[Chore] Next release? #799

noraj opened this issue Mar 19, 2020 · 3 comments

Comments

@noraj
Copy link

noraj commented Mar 19, 2020

Python 3.8 introduced a warning.

It's already fixed:

https://github.com/SecureAuthCorp/impacket/blob/0056b61ca52e13acf05d101518976980f1592d85/examples/GetUserSPNs.py#L445

Last release was 09/2019, is a release planned soon ?

Configuration

impacket version: v0.9.20
Python version: 3.8
Target OS: ArchLinux

Debug Output With Command String

$ GetUserSPNs.py --help
/usr/bin/GetUserSPNs.py:438: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if userDomain is '':
Impacket v0.9.20 - Copyright 2019 SecureAuth Corporation
...

Similar in all other scripts.

Additional context

Space for additional context, investigative results, suspected issue.

@asolino
Copy link
Collaborator

asolino commented Mar 19, 2020

We're planning on releasing next week. Keep in mind it is just a plan.

@asolino asolino closed this as completed Mar 19, 2020
@noraj
Copy link
Author

noraj commented Mar 19, 2020

@asolino Nice. No worry no urgency 😉

@noraj
Copy link
Author

noraj commented Mar 21, 2020

I'm waiting for 2 breaking fix #711 (digestmod) and 4a5403c to fix dirkjanm/BloodHound.py#41 (comment) that are already included in 0.9.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants