remove duplicate code related to ccache loadfile #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmaksimov
force-pushed
the
remove-duplicate-code
branch
from
36df745
to
921cc05
Compare
Closed
martingalloar
suggested changes
Feb 9, 2022
0xdeaddood
pushed a commit
to 0xdeaddood/impacket
that referenced
this pull request
Mar 5, 2022
- Parsing v3 and v4 ccache files to check fortra#1106 (and not support for v1 and v2) - Parsing creds from kirbi to check fortra#1254 - Checking fortra#1166 parseFile function
Closed
|
thanks for the review, i seem to have fixed all the requested things |
Merged
|
thanks a lot for this PR @rmaksimov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the parseFile function to ccache.py and have refactored all the duplicate code in other scripts