-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcpp cannot handle our code: What's the best path forward? #600
Comments
Yep, that's the correct fix. I switched to
Line 169 in 141b80a
Stick a |
Okay. I think I see the issue:
for some reason, pcpp is putting in an extra space in a LOT of calls. So it's getting |
Okay. Issue filed at pcpp, ned14/pcpp#84, but I'm guessing the fact we seem to rely on |
Ah, that's a pain! This is probably worth turning into a FAQ, I imagine it will come up again |
Yeah. And it looks like it's a wontfix for the pcpp folks (as expected). As I said in that issue, the "right" thing is to wait for the Fortran 202Y Standard Preprocessor and we can make a |
Also, as an aside, I think the readthedocs here still points to the Ford 6 info. That's why I was a bit confused about the pcpp stuff. |
In Ford 7,
pcpp
is now the default preprocessor. We've found that with MAPL this does not work, see https://github.com/GEOS-ESM/MAPL/actions/runs/6933072181/job/18858418856 for an example.We can duplicate this locally on a mac if
pcpp
is installed. Now, MAPL is pretty complex Fortran with lots of includes to gFTL which is a quite complex set of macros, perhapspcpp
does not like it?We can "fix" this issue by adding:
in our control file and all is well.
So, what is the right path forward? This seems a bug in
pcpp
but I'm not sure internally howpcpp
is called by Ford. @ZedThree Can you tell me how I could work on getting a reproducer to thepcpp
folks to show them they have an issue?cc: @JulesKouatchou
The text was updated successfully, but these errors were encountered: