Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to let Ford docs work #2453

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fixes to let Ford docs work #2453

merged 2 commits into from
Dec 1, 2023

Conversation

mathomp4
Copy link
Member

Description

This PR adds some fixes to the Ford control file to:

  1. Use cpp instead of pcpp as pcpp has issues with MAPL (see pcpp cannot handle our code: What's the best path forward? Fortran-FOSS-Programmers/ford#600)
  2. Fix up excludes to ignore warnings.

Related Issue

Motivation and Context

Let's the docs build

How Has This Been Tested?

Tested in CI on fork.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added 📝 Documentation Improvements or additions to documentation 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Skip Changelog labels Nov 27, 2023
@mathomp4 mathomp4 marked this pull request as ready for review November 27, 2023 16:28
@mathomp4 mathomp4 requested a review from a team as a code owner November 27, 2023 16:28
@tclune tclune merged commit 76ac64b into main Dec 1, 2023
27 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-ford-cpp branch December 1, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📝 Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants