Improve Lua angle/vectors a bit #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add player:GetEyeAngles()
- Add __tostring() implementations for Vector and QAngle classes
- Convert VectorAngles and AngleVectors to use Lua-style return values rather than C++ style pass-by-reference parameters. Example usage of the new functions:
local eye_angles = player:GetEyeAngles()
local forward, right, up = AngleVectors(eye_angles)
local angles = VectorAngles(forward)
assert(angles == eye_angles)
Note: This change is NOT backwards compatible, but as far as I can tell, no existing Lua scripts use either VectorAngles or AngleVectors currently (at least none that I have downloaded on my computer)
|
Seems fine, whats this for? |
|
No specific purpose, just something I noticed could be improved when testing other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add player:GetEyeAngles()
Add __tostring() implementations for Vector and QAngle classes
Convert VectorAngles and AngleVectors to use Lua-style return values rather than C++ style pass-by-reference parameters. Example usage of the new functions:
local eye_angles = player:GetEyeAngles()
local forward, right, up = AngleVectors(eye_angles)
local angles = VectorAngles(forward)
assert(angles == eye_angles)
Note: This change is NOT backwards compatible, but as far as I can tell, no existing Lua scripts use either VectorAngles or AngleVectors currently (at least none that I have downloaded on my computer)