Add sql based filters #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,45 @@ | |||
| module FortyFacets | |||
| class ScopeFacetFilterDefinition < FilterDefinition | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at class body beginning.
TobiasBales
force-pushed
the
scope_filters
branch
from
6cd6243
to
6d290a4
Compare
| assert_equal 6, search.result.size | ||
| search = MovieSearch.new("search" => { "classics" => "non_classics" }) | ||
| assert_equal 34, search.result.size | ||
| search = MovieSearch.new("search" => { "classics" => ["non_classics", "classics"] }) |
TobiasBales
force-pushed
the
scope_filters
branch
from
6d290a4
to
518c57a
Compare
| end | ||
|
|
||
| def facet | ||
| query = definition.queries.map { |key, query| "(#{query}) as #{key}" }.join(', ') |
There was a problem hiding this comment.
Shadowing outer local variable - query.
Line is too long. [89/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| counts.map do |count| | ||
| definition.queries.each do |key, _| | ||
| result[key] ||= 0 | ||
| result[key] += count.occurrences if [1, '1', true].include?(count[key]) |
There was a problem hiding this comment.
Line is too long. [83/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
TobiasBales
force-pushed
the
scope_filters
branch
from
518c57a
to
4cdd532
Compare
|
|
||
| counts = without.result.reorder("") | ||
| .select(query) | ||
| .group(definition.queries.keys) |
There was a problem hiding this comment.
Place the . on the previous line, together with the method call receiver.
Align the operands of an expression in an assignment spanning multiple lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.