Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI/riverpod tests cases #118

Closed
ashitaprasad opened this issue Feb 22, 2024 · 14 comments
Closed

Add UI/riverpod tests cases #118

ashitaprasad opened this issue Feb 22, 2024 · 14 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ashitaprasad
Copy link
Member

Tell us about the task you want to perform and are unable to do so because the feature is not available
Currently, API Dash has Unit tests & Widget tests, but needs support for adding UI tests which involves injecting riverpod states and testing the behaviour of screens. This will help improve the code coverage.

@ashitaprasad ashitaprasad added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2024
@sixtusagbo
Copy link
Contributor

I'll like to work on this.

I went through the contribution guidelines and the second step is to comment on the issue. I want to fork the repo and run it locally now.

@sixtusagbo
Copy link
Contributor

I've run the app and the tests and I'm getting started on the UI tests now

@ashitaprasad
Copy link
Member Author

Awesome @sixtusagbo, you can send across a PR once you are done writing tests.

@animator animator changed the title Add UI tests cases Add UI/riverpod tests cases Mar 9, 2024
@sixtusagbo
Copy link
Contributor

So, I had school exams that I just concluded yesterday. I'm fully available from now. I'm working on the tests and I'll send across a PR when I'm done.

@animator
Copy link
Member

Awesome @sixtusagbo 👍

@sixtusagbo
Copy link
Contributor

I've written tests for some of the providers. We'll be on break during the GSoC period so I have all the time to work on this project.

@ashitaprasad
Copy link
Member Author

@sixtusagbo Please send across a PR as soon as possible so that we can review the approach and provide feedback.

@sixtusagbo
Copy link
Contributor

I've done that, while I wait. I want to round up the Enter Key creates a new entry for "Add Param" and "Add Header"

@animator
Copy link
Member

@sixtusagbo that issue has already been resolved and is in the final stages of review. Kindly work on adding more UI tests.

@sixtusagbo
Copy link
Contributor

Okay

@Tanish2002
Copy link
Contributor

@ashitaprasad @animator This issue can be closed now I believe.

@sixtusagbo
Copy link
Contributor

I don't think so. There are other test cases I'm working on. I just haven't updated remote yet. And I have an approach for the mock. I had to modify the request() helper method in http_services.dart

@Tanish2002
Copy link
Contributor

Ah my bad, the linked PR was closed so I thought it was fine.

@sixtusagbo sixtusagbo mentioned this issue Mar 26, 2024
5 tasks
@sixtusagbo
Copy link
Contributor

I'll open a PR on my progress before the end of the week. I added more tests. My goal is to finish saveDataStateProvider, clearDataStateProvider, hasUnsavedChangesProvider, nameTextFieldFocusNodeProvider and searchQueryProvider before the actual GSoC coding week begins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants