Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version pinning #10

Closed
niccokunzmann opened this issue Sep 10, 2017 · 3 comments
Closed

Use version pinning #10

niccokunzmann opened this issue Sep 10, 2017 · 3 comments
Labels
has-PR

Comments

@niccokunzmann
Copy link
Member

We want this app to work for a long time. Versions of modules change, please pin the version of the used python packages in the requirements.txt file. (Reasoning)

You can use pip-tools for this: pip install pip-tools.
@niccokunzmann niccokunzmann changed the title Use verison pinning Use version pinning Sep 10, 2017
@jajodiaraghav
Copy link
Contributor

Can I take this? Will submit a PR soon

@niccokunzmann
Copy link
Member Author

Sure, please let us know about your progress here.

@jajodiaraghav jajodiaraghav mentioned this issue Sep 10, 2017
Merged
@fossasia-bot fossasia-bot bot added the has-PR label Sep 10, 2017
@jajodiaraghav
Copy link
Contributor

@niccokunzmann I used pip-tools. Have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niccokunzmann @jajodiaraghav