Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open profile link in new tab #47

Closed
liveHarshit opened this issue Oct 26, 2018 · 3 comments
Closed

Open profile link in new tab #47

liveHarshit opened this issue Oct 26, 2018 · 3 comments
Labels
GCI Task good first issue Good for newcomers

Comments

@liveHarshit
Copy link
Member

Actual Behaviour

Profile links are open in the same tab after clicking.

Expected Behaviour

Links should open with a blank target.
@liveHarshit liveHarshit mentioned this issue Oct 26, 2018
Closed
3 tasks
@Sid911 Sid911 mentioned this issue Oct 26, 2018
Closed
3 tasks
@realslimshanky realslimshanky added the good first issue Good for newcomers label Oct 26, 2018
@AppleC4T
Copy link
Contributor

Working on it, almost done.

@liveHarshit
Copy link
Member Author

Make sure PR is related to only this issue.

@AppleC4T
Copy link
Contributor

@liveHarshit Can I also add my student profile (related to this task: https://codein.withgoogle.com/dashboard/task-instances/6719288925749248/ )? I can't find an issue related to this.

liveHarshit pushed a commit that referenced this issue Oct 27, 2018
@AppleC4T @liveHarshit
Update student profile and fix links target (#47)
d1e6428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GCI Task good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abishekvashok @realslimshanky @liveHarshit @AppleC4T