Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt height of top bar and simplify search box #34

Closed
2 tasks done
mariobehling opened this issue Oct 15, 2016 · 3 comments
Closed
2 tasks done

Adapt height of top bar and simplify search box #34

mariobehling opened this issue Oct 15, 2016 · 3 comments
Labels
design enhancement Hacktoberfest

Comments

@mariobehling
Copy link
Member

mariobehling commented Oct 15, 2016 •
edited by jigyasa-grover
Loading

screenshot from 2016-10-15 15 48 53

  • Please implement the same height as the Google search bar.
  • Currently the search gets a blue kind of shadow, when it is highlighted. Please only change the line color to blue and do not show a box shadow.
@hemantjadon hemantjadon mentioned this issue Oct 15, 2016
Merged
jigyasa-grover added a commit that referenced this issue Oct 15, 2016
@jigyasa-grover
Merge pull request #35 from hemantjadon/angular2
e57ab3b 
Fixes #34: No box shadow on search bar
@hemantjadon hemantjadon mentioned this issue Oct 15, 2016
Merged
@hemantjadon
Copy link
Contributor

@jig08
I have tried and match the heights within 1px. PR #36

jigyasa-grover added a commit that referenced this issue Oct 15, 2016
@jigyasa-grover
Merge pull request #36 from hemantjadon/angular2
b117cb4 
Fixes #34: Header and search-bar heights adjust
@mariobehling
Copy link
Member Author

Cannot confirm this as solved. Please compare.

screenshot from 2016-10-15 23 57 26

Please also test on different browsers.

screenshot from 2016-10-15 23 58 40

@mariobehling mariobehling reopened this Oct 15, 2016
@hemantjadon hemantjadon mentioned this issue Oct 16, 2016
Merged
mariobehling added a commit that referenced this issue Oct 16, 2016
@mariobehling
Merge pull request #37 from hemantjadon/angular2
aac88db 
Fixes #27,#34:Footer menu cross-browser ui patches
@mariobehling
Copy link
Member Author

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design enhancement Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mariobehling @jigyasa-grover @hemantjadon