feat: Implement system of role invites #1680

ShridharGoel · 2019-05-30T20:25:23Z

Fixes #1678

Changes:

Implemented the system of role invitations.

GIF:

ci-reporter · 2019-05-30T20:31:22Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of ac260e8. Here's the output:

`Test Coverage`

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for ac260e8

`Test Coverage`

Failed build for a94bb88

`Test Coverage`

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

ci-reporter · 2019-05-30T20:31:23Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of a94bb88. Here's the output:

`Test Coverage`

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

liveHarshit

The build is failing. You need to do changes in CreateSpeakersCallViewModelTest.java also.

ShridharGoel · 2019-05-31T06:19:45Z

The build is failing. You need to do changes in CreateSpeakersCallViewModelTest.java also.

@liveHarshit Tests are passing locally and there are no changes related to CreateSpeakersCallViewModel in this. Updated the branch and the build has restarted, it should pass.

liveHarshit · 2019-05-31T06:29:20Z

it should pass.

Nope. It will fail. Please check EventsViewModelTest.java file

ShridharGoel · 2019-05-31T06:44:26Z

it should pass.

Nope. It will fail. Please check CreateSpeakersCallViewModelTest.java file

There are no changes related to that. And Travis has passed successfully. Not sure why CircleCI is failing.

liveHarshit · 2019-05-31T07:04:56Z

There are no changes related to that.

Yes but these test files should match, that's why the build is failing. Let me check the changes.

liveHarshit · 2019-05-31T07:13:28Z

No changes detected in this PR, but it is showing java.lang.NullPointerException at EventsViewModelTest.java:51 at private static final String DATE = DateUtils.formatDateToIso(LocalDateTime.now());

ShridharGoel · 2019-05-31T12:39:36Z

Build is passing now.

liveHarshit · 2019-05-31T15:31:10Z

GIF or screenshots, so I can understand the implementation because I'm not much familiar with orga app?

ShridharGoel · 2019-05-31T17:02:06Z

@liveHarshit Added GIF in issue description. Also, you can check Open Event Frontend to see the implementation and working on the website.

app/src/main/java/com/eventyay/organizer/core/roleinvite/RoleInviteFragment.java

anhanh11001

If you have tested that it can invite roles correctly then the code looks good to me

ShridharGoel · 2019-06-01T08:44:59Z

If you have tested that it can invite roles correctly then the code looks good to me

Yes, the invitation mail is being sent to the email address provided.

* build(deps): bump appcompat from 1.1.0-alpha04 to 1.1.0-alpha05 (#1634) Bumps appcompat from 1.1.0-alpha04 to 1.1.0-alpha05. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-compiler from 2.1.0-alpha04 to 2.2.0-alpha01 (#1633) Bumps lifecycle-compiler from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump recyclerview from 1.1.0-alpha04 to 1.1.0-alpha05 (#1630) Bumps recyclerview from 1.1.0-alpha04 to 1.1.0-alpha05. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump annotation from 1.1.0-beta01 to 1.1.0-rc01 (#1628) Bumps annotation from 1.1.0-beta01 to 1.1.0-rc01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-common-java8 from 2.1.0-alpha04 to 2.2.0-alpha01 (#1631) Bumps lifecycle-common-java8 from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * fix: Remove sticky headers from Attendees fragment (#1636) * build(deps): bump lifecycle-extensions from 2.1.0-alpha04 to 2.2.0-alpha01 (#1629) Bumps lifecycle-extensions from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump core-testing from 2.1.0-alpha02 to 2.1.0-beta01 (#1635) Bumps core-testing from 2.1.0-alpha02 to 2.1.0-beta01. Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump lifecycle-runtime from 2.1.0-alpha04 to 2.2.0-alpha01 (#1632) Bumps lifecycle-runtime from 2.1.0-alpha04 to 2.2.0-alpha01. Signed-off-by: dependabot[bot] <support@dependabot.com> * fix: Prevent closing of Edit Event without confirmation dialog (#1639) * chore: Convert SalesSummaryPresenter to ViewModel (#1642) * feat: Pagination in Attendees list (#1637) * fix: Prevent crash at check-in on second page onwards (#1647) * chore: Add unit tests for SalesSummaryViewModel (#1644) * chore: Add unit tests for SalesSummaryViewModel * chore: Add unit tests for SalesSummaryViewModel * feat: Integrate Error Prone (#1582) * feat: Integrate error prone * Update Error Prone version * build(deps): bump threetenbp from 1.3.8 to 1.4.0 (#1640) Bumps [threetenbp](https://github.com/ThreeTen/threetenbp) from 1.3.8 to 1.4.0. - [Release notes](https://github.com/ThreeTen/threetenbp/releases) - [Changelog](https://github.com/ThreeTen/threetenbp/blob/master/RELEASE-NOTES.md) - [Commits](ThreeTen/threetenbp@v1.3.8...v1.4.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * build(deps): bump gradle from 3.4.0 to 3.4.1 (#1645) Bumps gradle from 3.4.0 to 3.4.1. Signed-off-by: dependabot[bot] <support@dependabot.com> * chore: Update LeakCanary (#1649) * fix: Refresh Sponsors list automatically on deletion of items (#1651) * fix: Update Sponsors list automatically on creation of new item (#1652) * build(deps): bump logging-interceptor from 3.14.1 to 3.14.2 (#1655) Bumps logging-interceptor from 3.14.1 to 3.14.2. Signed-off-by: dependabot[bot] <support@dependabot.com> * chore: Migrate FeedbackListPresenter to ViewModel (#1657) * chore: Migrate FeedbackListPresenter to ViewModel * chore: Migrate FeedbackListPresenter to ViewModel * chore: Migrate FaqListPresenter to ViewModel (#1659) * fix: Dismiss clear button when amount becomes zero (#1421) * fix: Dismiss clear button when amount becomes zero * fix: Dismiss clear button when amount becomes zero * Fix style problem * Add space after if * Update README.md * Delete .gitkeep * fix: DatePicker and TimePicker doesn't display time chosen before when clicked (#1551) Changes: - Retain value of current time so in the AbstractDateTimePicker class Fixes #1548 * fix: Prevent crash on refreshing Event Dashboard (#1675) * fix: Update check-in system to work properly (#1673) * fix: Update check-in system to work properly * fix: Update check-in system to work properly * fix: Update check-in system to work properly * build(deps): bump mockito-inline from 2.27.0 to 2.28.1 (#1677) Bumps [mockito-inline](https://github.com/mockito/mockito) from 2.27.0 to 2.28.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v2.27.0...v2.28.1) * build(deps): bump mockito-inline from 2.28.1 to 2.28.2 (#1679) Bumps [mockito-inline](https://github.com/mockito/mockito) from 2.28.1 to 2.28.2. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v2.28.1...v2.28.2) Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump espresso-core from 3.2.0-beta01 to 3.2.0 (#1682) Bumps espresso-core from 3.2.0-beta01 to 3.2.0. Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump material from 1.1.0-alpha06 to 1.1.0-alpha07 (#1681) Bumps [material](https://github.com/material-components/material-components-android) from 1.1.0-alpha06 to 1.1.0-alpha07. - [Release notes](https://github.com/material-components/material-components-android/releases) - [Commits](https://github.com/material-components/material-components-android/commits) Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * feat: Implement system of role invites (#1680) * feat: Implement system of role invites * feat: Implement system of role invites * Update unit tests * feat: Implement system of role invites * feat: Implement system of role invites * fix: Prevent unresponsive FAQ fragment issue (#1687) * build(deps): bump gradle-errorprone-plugin from 0.8 to 0.8.1 (#1688) Bumps gradle-errorprone-plugin from 0.8 to 0.8.1. Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * fix: Show correct state of map display checkbox (#1692) * build(deps): bump recyclerview from 1.1.0-alpha05 to 1.1.0-alpha06 (#1697) Bumps recyclerview from 1.1.0-alpha05 to 1.1.0-alpha06. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump annotation from 1.1.0-rc01 to 1.1.0 (#1695) Bumps annotation from 1.1.0-rc01 to 1.1.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * build(deps): bump appcompat from 1.1.0-alpha05 to 1.1.0-beta01 (#1696) Bumps appcompat from 1.1.0-alpha05 to 1.1.0-beta01. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com> * feat: Implement notifications section (#1694) * feat: Implement notifications section * Remove item divider * Remove unused imports * chore: Bump version code and name for release of v1.2.0 (#1703)

ShridharGoel added 2 commits May 31, 2019 01:16

feat: Implement system of role invites

b389fba

feat: Implement system of role invites

3dc6620

auto-label bot added the feature label May 30, 2019

fossasia deleted a comment May 30, 2019

liveHarshit reviewed May 31, 2019

View reviewed changes

fossasia deleted a comment May 31, 2019

ShridharGoel requested review from liveHarshit and anhanh11001 May 31, 2019 14:51

fossasia deleted a comment May 31, 2019

ShridharGoel added 4 commits June 1, 2019 00:35

Update unit tests

0bf8951

feat: Implement system of role invites

d9a497b

feat: Implement system of role invites

5d80638

Merge branch 'development' into implement-role-invites

67f5f17

fossasia deleted a comment May 31, 2019

liveHarshit approved these changes Jun 1, 2019

View reviewed changes

app/src/main/java/com/eventyay/organizer/core/roleinvite/RoleInviteFragment.java Show resolved Hide resolved

anhanh11001 approved these changes Jun 1, 2019

View reviewed changes

iamareebjamal merged commit f3dde17 into fossasia:development Jun 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement system of role invites #1680

feat: Implement system of role invites #1680

ShridharGoel commented May 30, 2019 •

edited

ci-reporter bot commented May 30, 2019 •

edited

`Test Coverage`

`Test Coverage`

ci-reporter bot commented May 30, 2019

liveHarshit left a comment

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019 •

edited

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019

liveHarshit commented May 31, 2019 •

edited

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019

ShridharGoel commented May 31, 2019

anhanh11001 left a comment

ShridharGoel commented Jun 1, 2019

feat: Implement system of role invites #1680

feat: Implement system of role invites #1680

Conversation

ShridharGoel commented May 30, 2019 • edited

ci-reporter bot commented May 30, 2019 • edited

The build is failing

Test Coverage

Test Coverage

Test Coverage

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

ci-reporter bot commented May 30, 2019

The build is failing

Test Coverage

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

liveHarshit left a comment

Choose a reason for hiding this comment

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019 • edited

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019

liveHarshit commented May 31, 2019 • edited

ShridharGoel commented May 31, 2019

liveHarshit commented May 31, 2019

ShridharGoel commented May 31, 2019

anhanh11001 left a comment

Choose a reason for hiding this comment

ShridharGoel commented Jun 1, 2019

ShridharGoel commented May 30, 2019 •

edited

ci-reporter bot commented May 30, 2019 •

edited

`Test Coverage`

`Test Coverage`

`Test Coverage`

`Test Coverage`

liveHarshit commented May 31, 2019 •

edited

liveHarshit commented May 31, 2019 •

edited